Revert "Add support for arrays in hashaggregate [databricks] (#6066)" #6679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…6066)" This reverts commit 122e107. Signed-off-by: Raza Jafri <[email protected]>
|
build |
ttnghia
approved these changes
Oct 3, 2022
abellina
pushed a commit
to abellina/spark-rapids
that referenced
this pull request
Oct 5, 2022
…6066)" (NVIDIA#6679) This reverts commit 122e107. Signed-off-by: Raza Jafri <[email protected]> Signed-off-by: Raza Jafri <[email protected]> Co-authored-by: Raza Jafri <[email protected]>
razajafri
added a commit
to razajafri/spark-rapids
that referenced
this pull request
Jan 6, 2023
…VIDIA#6066)" (NVIDIA#6679)" This reverts commit c05ac2d. Signed-off-by: Raza Jafri <[email protected]>
Merged
3 tasks
razajafri
added a commit
that referenced
this pull request
Jul 13, 2023
* Revert "Revert "Add support for arrays in hashaggregate [databricks] (#6066)" (#6679)" This reverts commit c05ac2d and adds tests * Add test for aggregation on array * updated docs --------- Signed-off-by: Raza Jafri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 122e107.
Cudf doesn't give us control over what aggregate it will use. This change was for Hashaggregates but the
Firstoperator could also use aHashaggregateand then try to sort the output but fails since sorting isn't yet supported by cudf for arraysSigned-off-by: Raza Jafri [email protected]